roberth listed
Evidence, not a verdict. Maintainer Mode grants nothing; nixpkgs committers do. Reviews in the synced data: the last 60 days and every open pull request.
1
merged unchanged after their review
a committer merged it later, with no push after the review
58
problems found
the author changed the pull request after their review asked for it
Last 50 reviews, and what came of each
#568009 nixos/nix: document that root is always a trusted user
2026-10-11 · approved · author Stunkymonkey
merged by the reviewer problem found
#569232 lib/modules: do not attempt to show def-value in `_module.check` error
2026-10-02 · changes requested · author MattSturgeon
changed after review problem found
merged by the reviewer problem found
#554986 nixos/terraform-backend: init module
2026-09-19 · changes requested · author KiaraGrouwstra
changed after review problem found
merged after changes problem found
#562026 tarsum: add license
2026-09-11 · changes requested · author GraysonTinker
changed after review problem found
#518717 nixos/modular-services: reload/restart on `configData` change
2026-09-04 · commented · author KiaraGrouwstra
changed after review problem found
#553735 lib.options: add `mkEnabledOption`
2026-08-18 · changes requested · author Malix-Labs
closed
#553364 lib.options: add `optionToDoc`
2026-08-16 · commented · author Malix-Labs
closed problem found
#509697 devShell interface
2026-07-20 · commented · author lisanna-dettwyler
changed after review problem found
#519015 docs: split out modular services options to a separate section
2026-07-08 · commented · author KiaraGrouwstra
changed after review
changed after review problem found
changed after review
#509008 Single package fixpoint step 2: add `mkPackage`
2026-04-13 · commented · author KiaraGrouwstra
changed after review
changed after review
changed after review
#463986 dockerTools: preserve xattrs from buildImage root-layer and layeredIm…
2026-01-15 · changes requested · author johanot
changed after review problem found
#475372 nixos/redlib: Make into modular service
2026-01-12 · commented · author Ericson2314
changed after review problem found
changed after review problem found
#461032 lib.makeOverridable: preserve constructor override and metadata attributes
2025-12-22 · approved · author ShamrockLee
merged by the reviewer
#459543 check-meta: init packageType
2025-11-18 · commented · author RossComputerGuy
changed after review problem found
#158513 nixos/pam: add pwquality
2025-10-19 · commented · author 06kellyjac
changed after review problem found
#451499 lib.types: add arrayOf type
2025-10-13 · commented · author HeitorAugustoLN
changed after review problem found
#440544 lib.ron: init
2025-09-24 · commented · author HeitorAugustoLN
changed after review problem found
#437972 lib.types.submoduleWith: add onlyDefinesConfig parameter
2025-09-14 · changes requested · author yunfachi
changed after review problem found
#141934 lib/attrsets: add filterAttrsRecursiveCond function
2025-08-31 · changes requested · author r-burns
changed after review
changed after review
changed after review problem found
#405317 lib.modules: init `mkAliasDefinitionsWith`; simplify `doRename`; add `withLocation`
2025-08-01 · commented · author MattSturgeon
changed after review problem found
changed after review problem found
#420575 stdenv: allow preserving meta fields in derivation
2025-07-23 · commented · author Princemachiavelli
changed after review problem found
#411293 nix: remove propagated-build-inputs when static
2025-07-13 · changes requested · author RossComputerGuy
open
#330293 upgrading.chapter.md - Added NixOS-Nix version table
2025-05-30 · commented · author Denperidge
open
#410779 lib/attrsets: make getFirstOutput support strings
2025-05-25 · changes requested · author pbsds
changed after review problem found
changed after review problem found
changed after review problem found
#387173 dockerTools: add `CMD` override support to `streamNixShellImage`
2025-04-26 · commented · author commiterate
changed after review problem found
changed after review problem found
#334680 lib/types: add `record` (simplified submodule)
2025-04-09 · commented · author MattSturgeon
changed after review
Credit: 3.78, reciprocity 0% (decides listing only; reciprocity is shown, never acted on)
review of #573629 nixVersions: 2.35.2 -> 2.35.3, 2.34.8 -> 2.34.9, 2.31.5 -> 2.31.6, 2.30.5 -> 2.30.6, 2.28.7 -> 2.28.8, 2.36pre20261010 -> 2.36pre20261013 by xokdvium
2026-10-13 · merged · picked fresh ×0.5
0.47 of 0.50
review of #568009 nixos/nix: document that root is always a trusted user by Stunkymonkey
2026-10-11 · author pushed, author replied, comment on a changed line, merged · picked fresh ×0.5
0.45 of 0.50
review of #569232 lib/modules: do not attempt to show def-value in `_module.check` error by MattSturgeon
2026-10-02 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.37 of 0.50
review of #512758 lib.modules: document mkOverride by leana8959
2026-09-27 · author pushed, comment on a changed line, merged
0.65 of 1.00
review of #554986 nixos/terraform-backend: init module by KiaraGrouwstra
2026-09-19 · author pushed, author replied, comment on a changed line · repeat author ×0.5
0.27 of 0.50
review of #495303 Contract for files containing secrets by ibizaman
2026-09-18 · comment on a changed line
0.53 of 1.00
review of #562912 ci: point documentation PRs at the styleguide by hsjobeki
2026-09-14 · author pushed, author replied, comment on a changed line, merged · picked fresh ×0.5
0.24 of 0.50
review of #562026 tarsum: add license by GraysonTinker
2026-09-11 · author pushed, author replied · picked fresh ×0.5
0.22 of 0.50
review of #553735 lib.options: add `mkEnabledOption` by Malix-Labs
2026-08-18 · author replied · picked fresh ×0.5, repeat author ×0.5
0.06 of 0.25
review of #553364 lib.options: add `optionToDoc` by Malix-Labs
2026-08-16 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.12 of 0.50
review of #551387 sm64baserom: fix meta.position by jopejoe1
2026-08-11 · author replied, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.05 of 0.25
review of #551391 terraform_plugins_test: set pname and version by jopejoe1
2026-08-11 · author replied · picked fresh ×0.5
0.11 of 0.50
review of #518717 nixos/modular-services: reload/restart on `configData` change by KiaraGrouwstra
2026-07-24 · author pushed, comment on a changed line
0.14 of 1.00
review of #519015 docs: split out modular services options to a separate section by KiaraGrouwstra
2026-05-12 · comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.01 of 0.25
review of #518660 formats/plist: support base64 encoded binary data by Enzime
2026-05-11 · comment on a changed line · picked fresh ×0.5
0.01 of 0.50
review of #509697 devShell interface by lisanna-dettwyler
2026-04-28 · author pushed, author replied, comment on a changed line
0.02 of 1.00
review of #512256 lib/modules: expanded error message when no options defined by Notarin
2026-04-25 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.01 of 0.50
review of #504934 euro-office-documentserver: init at 9.3.4-hotfix.1 by onny
2026-04-16 · comment on a changed line
0.01 of 1.00
review of #509008 Single package fixpoint step 2: add `mkPackage` by KiaraGrouwstra
2026-04-13 · comment on a changed line · picked fresh ×0.5
0.01 of 0.50
review of #507676 nixos: allow core modules to be evaluated more independently. by phaer
2026-04-08 · author replied · picked fresh ×0.5
0.01 of 0.50
review of #507394 lib.systems.equals: hardcode function attr names by zimbatm
2026-04-07 · author replied, comment on a changed line · picked fresh ×0.5
0.01 of 0.50
review of #500702 lib/types: deprecate 'lib.types.types' by hsjobeki
2026-03-17 · author replied · picked fresh ×0.5
0.00 of 0.50
review of #427694 docker: copy signatures into container by h0nIg
2026-02-08 · comment on a changed line
0.00 of 1.00
review of #463986 dockerTools: preserve xattrs from buildImage root-layer and layeredIm… by johanot
2026-01-15 · author pushed, author replied
0.00 of 1.00
review of #453923 dockerTools: Refactor common writing code into writeImageStream by jhol
2026-01-06 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #475372 nixos/redlib: Make into modular service by Ericson2314
2026-01-02 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #461032 lib.makeOverridable: preserve constructor override and metadata attributes by ShamrockLee
2025-12-22 · merged
0.00 of 1.00
review of #459543 check-meta: init packageType by RossComputerGuy
2025-11-18 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #158513 nixos/pam: add pwquality by 06kellyjac
2025-10-19 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #445774 lib/modules: add 'index' to module.args of listOf submodule by hsjobeki
2025-10-14 · comment on a changed line
0.00 of 1.00
review of #451499 lib.types: add arrayOf type by HeitorAugustoLN
2025-10-13 · author pushed, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #440544 lib.ron: init by HeitorAugustoLN
2025-09-24 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #437972 lib.types.submoduleWith: add onlyDefinesConfig parameter by yunfachi
2025-09-14 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #141934 lib/attrsets: add filterAttrsRecursiveCond function by r-burns
2025-08-31 · author replied
0.00 of 1.00
review of #434262 nixos/phpfpm: set systemd Type to notify-reload when possible by aanderse
2025-08-19 · author replied · picked fresh ×0.5
0.00 of 0.50
review of #433695 flake: split into multiple files by mightyiam
2025-08-14 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #405317 lib.modules: init `mkAliasDefinitionsWith`; simplify `doRename`; add `withLocation` by MattSturgeon
2025-08-01 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #428540 lib: add new function that overrides possible args of drv by name-snrl
2025-07-26 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #428377 fetchFromGitHub: add archiveReproducibilityWorkaround option by YorikSar
2025-07-25 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #420575 stdenv: allow preserving meta fields in derivation by Princemachiavelli
2025-07-14 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #411293 nix: remove propagated-build-inputs when static by RossComputerGuy
2025-07-13 · comment on a changed line
0.00 of 1.00
review of #330293 upgrading.chapter.md - Added NixOS-Nix version table by Denperidge
2025-05-30 · comment on a changed line
0.00 of 1.00
review of #410779 lib/attrsets: make getFirstOutput support strings by pbsds
2025-05-25 · author pushed, author replied · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #401751 nixosMinimal: init - nixos with minimal modules by DavHau
2025-05-09 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #398456 Provide `key` attribute for anonymous modules created with mkRemovedOptionModule and mkRenamedOptionModule by nvmd
2025-05-04 · comment on a changed line
0.00 of 1.00
review of #390952 lib.modules: Expose the freeform results readonly via '_module.freeformConfig' by hsjobeki
2025-04-26 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #387173 dockerTools: add `CMD` override support to `streamNixShellImage` by commiterate
2025-04-26 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #399883 nixos/virtualization: add boolean option isVmVariant by pbsds
2025-04-19 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #370444 WIP: implement a secret vars store in nixpkgs by lassulus
2025-03-31 · author replied, comment on a changed line
0.00 of 1.00
review of #215198 tests.defaultPkgConfigPackages: Test `meta.pkgConfigModules` by Ericson2314
2025-02-16 · comment on a changed line
0.00 of 1.00
review of #380005 lib.systems: deprecate `==` comparison between elaborated platforms by MattSturgeon
2025-02-07 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #375424 mkPackageOption: add defaultText option by Pandapip1
2025-01-22 · author pushed, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #334680 lib/types: add `record` (simplified submodule) by MattSturgeon
2024-10-08 · author replied, comment on a changed line
0.00 of 1.00
review of #345913 nixos/nginx: report actual vhosts name in assertions/warnings by SuperSandro2000
2024-10-03 · author replied, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #342372 nixos/{assertions,warnings}: implement as tree-like attrs by h7x4
2024-09-22 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #336545 nixos/nix: move nix.nixPath into nix.settings.nix-path by SuperSandro2000
2024-08-25 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #326765 lib.network: ipv6 type, mkNetworkingOption and lib documentation by woojiq
2024-07-26 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #324058 lib.systems: do not confuse isStatic with hasSharedLibraries by tie
2024-07-03 · author pushed, author replied, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #323549 lib: add `filterMap` by nrdxp
2024-06-30 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #322733 lib: Document stability guarantee by infinisil
2024-06-27 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #317651 pkgsLinux: set crossSystem instead of localSystem by tie
2024-06-06 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #314058 lib.modules: add mkForAllItems by rhendric
2024-05-24 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #261660 Expose some additional nixosModules by sellout
2024-05-17 · author replied, comment on a changed line
0.00 of 1.00
review of #306307 testers: add more parameters, add testVersion to my maintained packages by Atemu
2024-04-23 · author pushed, author replied, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #304328 lib.attrsets.matchAttrTag: init by infinisil
2024-04-15 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #254212 Don't require ellipsis in NixOS module definitions. by vkryachko
2024-03-28 · comment on a changed line
0.00 of 1.00
review of #269586 lib.getOptionalAttrs: init by ShamrockLee
2024-03-26 · author pushed, author replied, comment on a changed line
0.00 of 1.00
review of #296979 lib: add option parameter for default value priority by Atemu
2024-03-25 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #297638 lib.types.deferredModuleWith: allow specialArgs by DavHau
2024-03-21 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #281331 Allow redeploying to interactive tests by Radvendii
2024-02-14 · author replied, comment on a changed line
0.00 of 1.00
review of #287633 formats.envvars: init by h7x4
2024-02-11 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #275753 `filterAttrsRecursive` improvements, `filterAttrsRecursiveTopDown` and `filterAttrsRecursiveBottomUp` by infinisil
2023-12-21 · comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #275760 `lib.converge`: Deprecate by infinisil
2023-12-21 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #272686 nixos/nixpkgs: Properly validate and merge nixpkgs config by dasJ
2023-12-07 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #263295 system-path: Remove `defaultPackages` option by l0b0
2023-10-26 · author pushed, author replied · picked fresh ×0.5
0.00 of 0.50
review of #262497 nixos/release.nix: remove unused withs by alyssais
2023-10-21 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #262047 nixos/top-level: fail more helpfully on forbidden dependencies by lheckemann
2023-10-19 · author pushed, author replied · picked fresh ×0.5
0.00 of 0.50
review of #261571 lib: CA fixes by Artturin
2023-10-17 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #256353 lib.types.stringLike: init by figsoda
2023-09-20 · author pushed, author replied · picked fresh ×0.5
0.00 of 0.50
review of #255086 nixos/system-path: convert environment.systemPackages to an attrset by r-vdp
2023-09-14 · author replied, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #254790 lib/types: init taggedSubmodule by lassulus
2023-09-12 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #246939 lib/types: Add `enumAttrs` and `enumWith` by one-d-wide
2023-08-12 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #245274 lib/modules/mk*Module: give resulting modules meaningful keys by sternenseemann
2023-07-25 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #245045 nixos/ssh: avoid IFD when using programs.ssh.knownHostsFiles by r-vdp
2023-07-23 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #234990 lib.simpleOptions: new function to simplify options declaration by hugosenari
2023-05-31 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #229361 Remove KVM assumption by mped-oticon
2023-05-11 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #221109 nixos: public evalSystemConfiguration interface by blaggacao
2023-03-14 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #216710 nixos-rebuild: use sudo when whoami != root by balsoft
2023-02-23 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #189837 services.nix-daemon: refactor into mkRemoteBuilderDesc by teto
2023-02-07 · comment on a changed line
0.00 of 1.00
review of #206619 lib: add apply and callWith by alex-ameen
2022-12-18 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #206096 Prevent `self-deploy` infinite reboot loop by Gabriella439
2022-12-14 · author pushed, comment on a changed line · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
0.00 of 1.00
review of #204020 Add `haskell.lib.incremental` utility by Gabriella439
2022-12-06 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #201844 trival-builders: add pre and post build hooks to runCommandWith by jmgilman
2022-11-20 · author replied · picked fresh ×0.5
0.00 of 0.50
review of #201734 fix splicing in overrideAttrs by Artturin
2022-11-18 · author pushed, author replied · picked fresh ×0.5, repeat author ×0.5
0.00 of 0.25
review of #201619 config.allowAliases: add NIXPKGS_ALLOW_ALIASES to have an easy way to by Artturin
2022-11-17 · author pushed, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #199281 doc: Describe list arguments to submodule by keks
2022-11-03 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #157161 nixosTests.nixos-test-driver: init by Synthetica9
2022-09-28 · comment on a changed line
0.00 of 1.00
review of #64691 types: Fix path.check for cleanSourceWith output by hamishmack
2022-09-23 · comment on a changed line
0.00 of 1.00
review of #188354 lib: Add find and findSuffix to lib.filesystem by MatthewCroughan
2022-08-29 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #185827 lib/modules: Throw better function-in-list error by infinisil
2022-08-09 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #181299 pre-commit: fix hook-tmpl patch by winterqt
2022-07-15 · author replied · picked fresh ×0.5
0.00 of 0.50
review of #179772 nixos/modules/flake/source-info: new module by herberteuler
2022-07-01 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #179471 lib.types, formats: Introduce a new `secret` type and use it for generalized secret replacements in `pkgs.formats` by talyz
2022-06-30 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #176295 nixos/version: Require a stateVersion by dasJ
2022-06-05 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #156752 nixos/grub: Show more info in the generation chooser by dasJ
2022-01-27 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #156613 testers.testGraphical: add by Synthetica9
2022-01-26 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #153551 nixosImages: add to pkgs by jonringer
2022-01-07 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #151219 vscode-with-extensions: allow extensions from user home by pasqui23
2021-12-18 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
0.00 of 1.00
review of #127848 xserver module: Make user-provided config render after default config by nh2
2021-12-16 · comment on a changed line
0.00 of 1.00
review of #144110 nixos/testing-python: Avoid infinite recursion in node definitions by talyz
2021-11-09 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #132617 mkShellMinimal: Create an ultra minimal nix-shell by fzakaria
2021-08-04 · author pushed, author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #122608 pkgs.dockertools.buildLayeredImage: customisable layering strategy by adrian-gierakowski
2021-05-11 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #119683 dockerTools: add support for ARM variants by piperswe
2021-04-17 · comment on a changed line · picked fresh ×0.5
0.00 of 0.50
review of #101127 nixos/defaults: init by deviant
2020-10-26 · author replied, comment on a changed line · picked fresh ×0.5
0.00 of 0.50