Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

pinocchio: fix build with gcc 16 #570749

merged MiniHarinn wants to merge into master · opened 11d ago
About
State
merged
Author
MiniHarinn member
Base
master
Labels
10.rebuild-linux: 11-10010.rebuild-darwin: 11-10012.approvals: 112.approved-by: package-maintainer
Age
11d ago, merged 10d ago by wegank
Size
+16 −0 in 2 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged
Approved head
Credit earned
nim65s · review 10d ago · 0.39
What it touches
pinocchio risk 2 2 0
maintainers nim65s, wegank · approved by nim65s
maintainers nim65s, wegank · approved by nim65s
Description

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Files changed 2

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 570749 Commit: 98c93312090e308e9716caa39f544b7143af75fc


x86_64-linux

<details> <summary>✅ 21 packages built:</summary> <ul> <li>pinocchio</li> <li>toppra</li> <li>ndcurves</li> <li>python313Packages.pinocchio</li> <li>python313Packages.example-robot-data</li> <li>python313Packages.tsid</li> <li>tsid</li> <li>python313Packages.ndcurves</li> <li>python314Packages.pinocchio</li> <li>python314Packages.example-robot-data</li> <li>python314Packages.ndcurves</li> <li>crocoddyl</li> <li>python314Packages.crocoddyl</li> <li>aligator</li> <li>python314Packages.aligator</li> <li>python314Packages.tsid</li> <li>python313Packages.crocoddyl</li> <li>python313Packages.aligator</li> <li>mim-solvers</li> <li>python314Packages.mim-solvers</li> <li>python313Packages.mim-solvers</li> </ul></details>
nim65s reviewed approved 10d ago

Nice, thanks !

We have the same issue with gcc15/clang for C++20.

Do you want to contribute that upstream ? that will be welcome :)

We have the same issue with gcc15/clang for C++20.

Do you want to contribute that upstream ? that will be welcome :)

I will give it a try!