Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

nodejs-slim_26: fix gcc16 build on aarch64-linux #570428

merged mweinelt wants to merge into master · opened 11d ago
Review on GitHub Open on GitHub
About
State
merged
Author
mweinelt member
Base
master
Labels
10.rebuild-linux: 11-10010.rebuild-darwin: 11-1006.topic: nodejs12.approvals: 112.approved-by: package-maintainer
Age
11d ago, merged 11d ago by aduh95
Size
+25 −0 in 2 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged
Approved head
none
Credit earned
aduh95 · review 11d ago · 0.38
How credit works
What it touches
nodejs-slim_26 risk 0 1 0
maintainers aduh95
nodejs-slim_latest risk 0 1 0
maintainers aduh95
Description

Fixes: #568974

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 2

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

aduh95 reviewed commented 11d ago

Can you please use the patch in https://chromium-review.googlesource.com/c/v8/v8/+/8500805?

mweinelt commented 11d ago

Vendored that patch instead. Mangled the paths as required.

aduh95 commented on pkgs/development/web/nodejs/memcpy-climits.patch:7 11d ago

nit: it would make sense to link to the source for reference

Bug: https://github.com/nodejs/node/pull/66497#issuecomment-5978321562
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8500805
aduh95 reviewed approved 11d ago
mweinelt commented on pkgs/development/web/nodejs/memcpy-climits.patch:7 11d ago

Added the Reviewed-on line.

From the archive of this server. The whole conversation on GitHub