Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

gcc: skip libc-ldflags-before if it doesn't exist #568104

open Pandapip1 wants to merge into staging · opened 2w ago
Review on GitHub Open on GitHub
About
State
open
Author
Pandapip1 member
Base
staging
Labels
10.rebuild-linux: 501+10.rebuild-darwin: 501+10.rebuild-linux-stdenv10.rebuild-darwin: 5001+10.rebuild-linux: 5001+9.needs: reviewer10.rebuild-nixos-tests7.no default reviewers
Age
2w ago, updated 2w ago
Size
+4 −1 in 1 file
Checks
checks pass
Mergeable
merges cleanly
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
Needs review: all
Why not ready
nobody approved the current head commit; no review on it earned credit yet
Approved head
none
Credit earned
none yet
How credit works
What it touches
gcc risk 0 13 3
maintainers vcunat, Ericson2314, balsoft, andir, pyrox0 · teams GCC, Security review
gcc-unwrapped risk 0 38 2
maintainers vcunat, Ericson2314, balsoft, andir, pyrox0 · teams GCC, Security review
gccForLibs risk 0 38 2
maintainers vcunat, Ericson2314, balsoft, andir, pyrox0 · teams GCC, Security review
libgcc risk 0 40 3
maintainers vcunat, Ericson2314, balsoft, andir, pyrox0 · teams GCC, Security review
libgccjit risk 0 38 3
maintainers vcunat, Ericson2314, balsoft, andir, pyrox0 · teams GCC, Security review
Description

Not all bintools (e.g. busybox) have nix-support/libc-ldflags-before. This fixes an error that shows up when that is the case (benign because of the || true but unnecessary noise and the existing approach is less readable).

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 1

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

No review or comment yet.
From the archive of this server. The whole conversation on GitHub