About
State
open
Author
yzhou216 member
Base
master
Labels
6.topic: python10.rebuild-darwin: 010.rebuild-linux: 0
Age
2w ago, updated 2d ago
Size
+71 −59 in 59 files
Checks
checks pass
Mergeable
merges cleanly
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
Needs review: all
Why not ready
nobody approved the current head commit
Approved head
none
Credit earned
AlexAntonik · review 2w ago · 0.32
What it touches
maintainers tboerger
maintainers GaetanLepage
maintainers khaneliman
maintainers niklaskorz
maintainers happysalada
maintainers happysalada
maintainers johnrtitor
maintainers luftmensch-luftmensch
maintainers HexSleeves, IogaMaster
maintainers matthiasbeyer
maintainers none
maintainers happysalada
maintainers fabaff
maintainers none
maintainers TomaSajt
maintainers Gigahawk
maintainers fabaff
maintainers fabaff
maintainers sarahec
maintainers Sigmanificient
maintainers fabaff
maintainers fabaff
maintainers fabaff
maintainers fabaff
maintainers malob
maintainers fabaff
maintainers alunduil
maintainers none
maintainers dibenzepin
maintainers none
maintainers felixzieger
maintainers doronbehar, kira-bruneau
maintainers niklaskorz
maintainers ShamrockLee
Description
Tracking #564638
Things done
- Built on platform:
- x86_64-linux
- aarch64-linux
- aarch64-darwin
- Tested, as applicable:
- NixOS tests in nixos/tests.
-
Package tests at
passthru.tests. - Tests in lib/tests or pkgs/test for functions and "core" functionality.
-
Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage. -
Tested basic functionality of all binary files, usually in
./result/bin/. - Nixpkgs Release Notes
- Package update: when the change is major or breaking.
- NixOS Release Notes
- Module addition: when adding a new NixOS module.
- Module update: when the change is significant.
- Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
- Follows the automation/AI policy.
Review checklist from CONTRIBUTING.md and pkgs/README.md
- The commit messages follow the nixpkgs format, like
hello: 2.12 -> 2.13ornixos/nginx: fix the test. Guide metais complete:description,homepage,license,maintainers,mainProgram. Guide- Sources are fixed-output and pinned by a hash. No
lib.fakeHashis left. Guide - A command-line tool has
versionCheckHook, or another check that runs it. Guide meta.platformsmatches what upstream supports. Guide- The tests run:
passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide - AI use is disclosed with an
Assisted-by:trailer. Guide
The title names what it changes. AI use: none disclosed in the last commit or the description.
Files changed 59
The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub
Reviews and comments
AlexAntonik commented 2w ago
Thanks for these! Tiny suggestion - if you're planning more PRs like this, taking a contiguous range (100–150) next time would make ticking them off in the tracking issue much easier.
license = with lib.licenses; OR [
As stated in commit message https://github.com/sbdchd/squawk/commit/5354eedcae4aec250aba5d61e61ef35eeae9008c
license = lib.licenses.gpl3Plus;
Should be GPL-3.0-or-later: the header in https://github.com/blacklanternsecurity/offensive-azure/blob/dev/offensive_azure/Azure_AD/get_subscriptions.py says either version 3 of the License, or (at your option) any later version.
license =
with lib.licenses;
AND [
gpl3Only
mpl20
bsd2
bsd3
];
https://github.com/tinted-theming/tinty/tree/v0.34.1#license