Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

ocis_5-bin, nixos/ocis: remove #566479

open Ramblurr wants to merge into master · opened 3w ago
About
State
open
Author
Ramblurr member
Base
master
Labels
6.topic: nixos8.has: documentation8.has: changelog8.has: module (update)2.status: merge conflict10.rebuild-linux: 1-1010.rebuild-darwin: 011.by: package-maintainer12.approvals: 112.approved-by: package-maintainerllm-assisted
Age
3w ago, updated 10d ago
Size
+7 −887 in 10 files
Checks
checks pending
Mergeable
not known yet
AI use
disclosed: pi
In Maintainer Mode
Queue
Needs review: all
Why not ready
checks are pending; GitHub has not said yet whether it merges cleanly; no review on it earned credit yet
Approved head
Credit earned
What it touches
nixos/rename no maintainer 7 0
maintainers none
maintainers bhankas, Ramblurr · approved by bhankas
ocis_5-bin risk 13 upstream 8.2.1 1 0
maintainers Ramblurr, bhankas · approved by bhankas
Description

Follow-up to #548482: remove ocis_5-bin and the NixOS module.

ocis_5-bin is far out of date (latest is 8), and oCIS requires a strict upgrade sequence, requiring every intermediate package. My attempt in #409138 to bring those packages stalled out despite review requests.

I was the only active maintainer, and I’m migrating away from oCIS in general.

Since 5 no longer supported by upstream anyways, it only makes sense to remove the pkg and module from nixpkgs.

cc @bhankas @dotlambda

AI assistance: Pi with OpenAI gpt-6-astra.

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: disclosed: pi.

Files changed 10

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

nixpkgs-ci reviewed commented 3w ago

Thanks for contributing to the documentation

Make sure you follow the documentation styleguide, most notably:

  • Show, don't tell: lead with a minimal working example; explanation follows the code.
  • No meta-commentary: don't write "This section explains how to…", just do it.
  • Imperative mood and active voice: "Run the command", not "The user should run the following command".
  • Present tense: "This creates a folder", not "This will create a folder".
  • Be confident: no hedging with "should", "might", "typically", "usually".
  • Cut filler words: "simply", "just", "easily", "basically"; "to", not "in order to".

For larger changes, like adding or removing whole sections, ask the NixOS documentation team for a review.

bhankas commented 3w ago

Hi @Ramblurr , thank you for your work on this. Super sorry for not being responsive enough, life has been busy.

Not sure if I mentioned this before, but I have moved away from OCIS since quite a while and wouldn't be a good judge for its reviewing anything related to it. If its not too much trouble I'd like to request you to also remove my name from maintainers. If it is trouble, no problem all the same, I'll get around to doing it when life permits.

Apologies again for non-response earlier, even this message is being typed from a phone on pu lic transport because thats just where things are :)

bhankas reviewed approved 3w ago
bhankas commented 3w ago

On second note, you removed the package and any maintainer ship with it. Approved!

bhankas commented 3w ago

@NixOS/nixpkgs-merge-bot merge

nixpkgs-ci commented 3w ago

@bhankas wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • :white_check_mark: PR targets a development branch.
  • :x: PR touches only files of packages in pkgs/by-name/.
  • :x: PR is at least one of:
    • :white_large_square: Approved by a committer.
    • :white_large_square: Backported via label.
    • :white_large_square: Opened by a committer.
    • :white_large_square: Opened by @r-ryantm.
  • :white_check_mark: PR is not a draft
  • :white_check_mark: PR is not blocked by a "changes requested" review from a committer.
  • :white_check_mark: bhankas is a member of @NixOS/nixpkgs-maintainers.

:x: Pull Request could not be merged (#305350)

bhankas commented 3w ago

❌ Pull Request could not be merged (#305350)

Oh well, I tried. @Ramblurr feel free to get anybody else to merge, I may not be able to check.this PR again in reasonable timespan.