Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

ntopng: 6.6 -> 7.0 #565944

merged bjornfor wants to merge into master · opened 3w ago
Review on GitHub Open on GitHub
About
State
merged
Author
bjornfor member
Base
master
Labels
1.severity: security8.has: package (update)10.rebuild-linux: 1-1010.rebuild-darwin: 1-1012.approvals: 1
Age
3w ago, merged 3w ago by bjornfor
Size
+8 −14 in 2 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged
Approved head
RumBugen
Credit earned
RumBugen · review 3w ago · 0.29
How credit works
What it touches
ndpi risk 26 1 advisory 0 0
maintainers takikawa
ntopng risk 34 1 advisory 0 1
maintainers bjornfor
Description

Things done

Update ntopng to the latest version (incl. dependency nDPI). Ref https://github.com/NixOS/nixpkgs/issues/565751. Not tested.

  • ndpi: 5.0 -> 6.0
  • ntopng: 6.6 -> 7.0
Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 2

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

nixpkgs-review-gha commented 3w ago

:white_check_mark: nixpkgs-review result

Generated using nixpkgs-review-gha (05be241)

Command: nixpkgs-review pr 565944 Commit: 83afc2f71913ba074bff587875525d9273085659 (subsequent changes) Merge: cd5e87cbc95e56e10781cc4924078598641d7d0f

Triggered by @RumBugen (43646118) Logs: https://github.com/RumBugen/nixpkgs-review-gha/actions/runs/35922904344/attempts/1

x86_64-linux

<details><summary>:white_check_mark: 3 packages built:</summary><ul> <li>netcap</li> <li>ndpi</li> <li>ntopng</li> </ul></details>

aarch64-linux

<details><summary>:white_check_mark: 3 packages built:</summary><ul> <li>netcap</li> <li>ndpi</li> <li>ntopng</li> </ul></details>

x86_64-darwin

:white_check_mark: No rebuilds

aarch64-darwin (sandbox = relaxed)

<details><summary>:white_check_mark: 2 packages built:</summary><ul> <li>ndpi</li> <li>netcap</li> </ul></details>
RumBugen reviewed approved 3w ago

I tested the basic core functionality and it works fine.

bjornfor commented 3w ago

@RumBugen: Thanks!

From the archive of this server. The whole conversation on GitHub