Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

[staging-26.05 backport] nodejs: fix build with latest OpenSSL #559833

merged aduh95 wants to merge into staging-26.05 · opened 6w ago
Review on GitHub Open on GitHub
About
State
merged
Author
aduh95 member
Base
staging-26.05
Labels
10.rebuild-linux: 501+10.rebuild-darwin: 501+11.by: package-maintainer6.topic: nodejs10.rebuild-darwin: 5001+10.rebuild-linux: 5001+4.workflow: backport9.needs: reviewer
Age
6w ago, merged 6w ago by aduh95
Size
+18 −0 in 3 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged
Approved head
none
Credit earned
none yet
How credit works
What it touches
nodejs-slim risk 0 0 1
maintainers aduh95
nodejs-slim_22 risk 0 1 0
maintainers aduh95
nodejs-slim_24 risk 0 0 0
maintainers aduh95
nodejs-slim_26 risk 0 1 0
maintainers aduh95
nodejs-slim_latest risk 0 1 0
maintainers aduh95
Description

Backport of:

  • https://github.com/NixOS/nixpkgs/pull/559648

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title does not start with name:. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 3

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

n0099 commented 5w ago

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 559833 --package-regex nodejs Commit: 67680953e3dd8215e186bba0b21d9a589c3d0284

x86_64-linux

<details> <summary>:x: 2 packages failed to build:</summary> <ul> <li>nodejs_22</li> <li>nodejs_26</li> </ul></details><details> <summary>:white_check_mark: 4 packages built:</summary> <ul> <li>nodejs-slim</li> <li>nodejs-slim_22</li> <li>nodejs-slim_26</li> <li>nodejsInstallExecutables</li> </ul></details>
From the archive of this server. The whole conversation on GitHub