Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

aioquic: fix build in Darwin sandbox #555599

closed maxbrunet wants to merge into staging · opened 7w ago
Review on GitHub Open on GitHub
About
State
closed
Author
maxbrunet member
Base
staging
Labels
6.topic: python10.rebuild-linux: 501+10.rebuild-darwin: 501+10.rebuild-linux: 501-100010.rebuild-darwin: 501-1000
Age
7w ago, closed 7w ago
Size
+138 −110 in 30 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is closed
Approved head
none
Credit earned
none yet
How credit works
What it touches
antigravity-cli risk 8 upstream 1.4.0 0 0
maintainers AdrielVelazquez, u3kkasha
basalt risk 0 0 0
maintainers faukah
bulk_extractor risk 7 no maintainer 0 0
maintainers none
cargo-binstall risk 0 0 0
maintainers mdaniels5757
chsrc risk 7 no maintainer 0 0
maintainers none
cliamp risk 1 1 0
maintainers supermarin
commons-logging risk 8 no maintainer 0 0
maintainers none
commonsLogging risk 8 no maintainer 0 0
maintainers none
container2wasm risk 7 no maintainer 0 0
maintainers none
editres risk 7 no maintainer 0 0
maintainers none
fuse-emulator risk 15 upstream 1.10.0 no maintainer 0 0
maintainers none
gl3w risk 8 no maintainer 0 0
maintainers none
go-sct risk 7 no maintainer 0 0
maintainers none
jacoco risk 7 no maintainer 0 0
maintainers none
kitex risk 7 no maintainer 0 0
maintainers none
labwc risk 6 no maintainer 0 0
maintainers none
lprobe risk 1 0 0
maintainers cageyv
necesse-server risk 1 0 0
maintainers n0rc
opengrok risk 15 upstream 1.14.20 no maintainer 1 0
maintainers none
pg_checksums risk 7 no maintainer 0 0
maintainers none
python3Packages.aioquic risk 0 0 0
maintainers onny
python3Packages.aioquic_1_2 risk 0 0 0
maintainers onny
python3Packages.cramjam risk 0 0 0
maintainers veprbl
python3Packages.holoviews risk 6 no maintainer 1 0
maintainers none
python3Packages.hvplot risk 0 0 0
maintainers locnide
python3Packages.intake risk 39 1 advisory no maintainer 1 0
maintainers none
quickjs-ng risk 7 no maintainer 0 0
maintainers none
ssh-vault risk 0 0 0
maintainers yzhou216
thruster risk 1 0 0
maintainers philocalyst
unimatrix risk 1 0 0
maintainers Anomalocaridid
xpr risk 7 no maintainer 0 0
maintainers none
yoshimi risk 7 no maintainer 0 0
maintainers none
Description

Disable failing test during darwin build with sandbox enabled:

    async with connect(host, port, configuration=configuration, **kwargs) as client:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/nix/store/kmq6qdcg0yq6r4awf02dgq003n42r6zk-python3-3.14.7/lib/python3.14/contextlib.py:214: in __aenter__
    return await anext(self.gen)
           ^^^^^^^^^^^^^^^^^^^^^
/nix/store/crrh9mkdcjhyfqhpvmgkdcwa3zvl1sg9-python3.14-aioquic-1.3.0/lib/python3.14/site-packages/aioquic/asyncio/client.py:93: in connect
    await protocol.wait_connected()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <aioquic.asyncio.protocol.QuicConnectionProtocol object at 0x10c2f9940>

    async def wait_connected(self) -> None:
        """
        Wait for the TLS handshake to complete.
        """
        assert self._connected_waiter is None, "already awaiting connected"
        if not self._connected:
            self._connected_waiter = self._loop.create_future()
>           await asyncio.shield(self._connected_waiter)
E           ConnectionError

/nix/store/crrh9mkdcjhyfqhpvmgkdcwa3zvl1sg9-python3.14-aioquic-1.3.0/lib/python3.14/site-packages/aioquic/asyncio/protocol.py:146: ConnectionError
=========================== short test summary info ============================
FAILED tests/test_asyncio.py::HighLevelTest::test_connect_and_serve_ipv4 - ConnectionError
=================== 1 failed, 469 passed in 90.25s (0:01:30) ===================

Caught while working on #553128

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 30

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

nixpkgs-branch-check reviewed changes requested 7w ago

The PR's base branch is set to master, and this PR causes 772 rebuilds. Please consider whether this PR causes a mass rebuild according to our conventions. If it does cause a mass rebuild, please change the base branch to the right base branch for your changes (probably staging). If it does not cause a mass rebuild, this message can be ignored.

nixpkgs-branch-check reviewed changes requested 7w ago

The PR's base branch is set to staging, but 58 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the master branch, change the base branch.
  • If the changes should go to the staging branch, rebase your PR onto the correct merge-base: 
    # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
git rebase --onto f58bbc7ea29d1a501cc1007759539616785dc9cf cbd8671ff90ee7fb085c63846159c44225a660f3
git push --force-with-lease
From the archive of this server. The whole conversation on GitHub