Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

xdg-desktop-portal: apply patch to fix graphical-session.target regression #548762

open NyCodeGHG wants to merge into master · opened 2mo ago
About
State
open
Author
NyCodeGHG member
Base
master
Labels
10.rebuild-linux: 11-10010.rebuild-darwin: 02.status: merge-bot eligible
Age
2mo ago, updated 2mo ago
Size
+39 −0 in 2 files
Checks
checks pending
Mergeable
not known yet
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
Needs review: all
Why not ready
checks are pending; GitHub has not said yet whether it merges cleanly; nobody approved the current head commit; no review on it earned credit yet
Approved head
none
Credit earned
What it touches
maintainers jtojnar
Description

xdg-desktop-portal.service doesn't start anymore on desktops which do not use graphical-session.target. See https://github.com/flatpak/xdg-desktop-portal/issues/1983#issuecomment-4651275776

Tested with nixosTests.mate-wayland.driverInteractive. xdg-desktop-portal.service failed to start before this patch, starts successfully afterwards.

Things done

Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Files changed 2

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

No review or comment yet.