Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

Upgrade ntopng to 6.6 #490337

merged bakhtiyarneyman wants to merge into master · opened 8mo ago
Review on GitHub Open on GitHub
About
State
merged
Author
bakhtiyarneyman contributor
Base
master
Labels
8.has: package (update)10.rebuild-linux: 1-1010.rebuild-darwin: 1-1010.rebuild-darwin: 112.approvals: 112.approved-by: package-maintainer12.first-time contribution
Age
8mo ago, merged 7mo ago by bjornfor
Size
+7 −4 in 2 files
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged; its author is not listed: credit from 0 of 3 authors
Approved head
bjornfor
Credit earned
bjornfor · review 7mo ago · 0.00
How credit works
What it touches
ndpi risk 26 1 advisory 0 0
maintainers takikawa
ntopng risk 34 1 advisory 0 1
maintainers bjornfor · approved by bjornfor
Description

Things done

Upgrade ntopng. Also upgrade nDPI because they need to be upgraded in lockstep.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title does not start with name:. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 2

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

bakhtiyarneyman commented 7mo ago

Hi, @bjornfor, is there anything to be done to kick off the review?

bjornfor reviewed approved 7mo ago

Patch looks good. I tested it on a system of mine on NixOS 25.11.

Thanks!

bjornfor commented 7mo ago

Hi, @bjornfor, is there anything to be done to kick off the review?

A reminder was apparently needed :-) Thanks for the PR!

LeSuisse commented 5d ago

I saw this PR updated nDPI to 6.0. Some of the dissectors are now dual licensed: https://www.ntop.org/announcing-ndpi-dual-license-change/ Should we update license on the nDPI package / move the unfree parts behind a flag?

From the archive of this server. The whole conversation on GitHub