Maintainer Mode
Sign in with GitHub
Work in progress. Maintainer Mode changes every day: pages, numbers and links can change or break. Tell us what is wrong or missing.

iterm2: fix on macOS 13 #186549

merged reckenrode wants to merge into master · opened 4y ago
Review on GitHub Open on GitHub
About
State
merged
Author
reckenrode member
Base
master
Labels
6.topic: darwin10.rebuild-darwin: 1-1010.rebuild-linux: 010.rebuild-darwin: 1
Age
4y ago, merged 4y ago by veprbl
Size
+2 −0 in 1 file
AI use
none disclosed in the last commit or the description
In Maintainer Mode
Queue
in no queue
Why not ready
it is merged
Approved head
none
Credit earned
none yet
How credit works
What it touches
iterm2 risk 10 upstream 3.7.6 0 0
maintainers tricktron, emaiax
python3Packages.iterm2 risk 0 0 0
maintainers jeremyschlatter
Description
Description of changes

The fixup phase runs patch-shebangs, which modifies the shell integration scripts included the iTerm2.app bundle. This causes iTerm2 to be identified as damaged on macOS 13, which prevents it from running. This is due to changes in macOS 13 that checks signatures every time a notarized app is run on macOS 13. Since iTerm2 is using upstream’s build due to entitlements, it is notarized and must not be modified.

See https://eclecticlight.co/2022/06/17/app-security-changes-coming-in-ventura/ for more details on the changes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
Review checklist from CONTRIBUTING.md and pkgs/README.md
  • The commit messages follow the nixpkgs format, like hello: 2.12 -> 2.13 or nixos/nginx: fix the test. Guide
  • meta is complete: description, homepage, license, maintainers, mainProgram. Guide
  • Sources are fixed-output and pinned by a hash. No lib.fakeHash is left. Guide
  • A command-line tool has versionCheckHook, or another check that runs it. Guide
  • meta.platforms matches what upstream supports. Guide
  • The tests run: passthru.tests, the NixOS test of a module, or nixpkgs-review. Guide
  • AI use is disclosed with an Assisted-by: trailer. Guide

The title names what it changes. AI use: none disclosed in the last commit or the description.

Review on GitHub Open on GitHub
Maintainer Mode posts nothing on nixpkgs. You leave your review on GitHub.

Files changed 1

The diff could not be read: this server reads GitHub only for people who sign in (sign in). Read it on GitHub

Reviews and comments

nixos-discourse commented 3y ago

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-on-macos-ventura/22733/6

From the archive of this server. The whole conversation on GitHub